Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outline] Add support for left or right positioned Outline #2035

Closed
4 tasks done
staghouse opened this issue Mar 4, 2023 · 0 comments · Fixed by #2138
Closed
4 tasks done

[Outline] Add support for left or right positioned Outline #2035

staghouse opened this issue Mar 4, 2023 · 0 comments · Fixed by #2138
Labels
theme Related to the theme

Comments

@staghouse
Copy link

staghouse commented Mar 4, 2023

Is your feature request related to a problem? Please describe.

I would like to move the Outline to the left of the main content which can be done relatively easily with CSS however the caveat is because when we use frontmatter to hide the outline on certain pages it creates a gap on the left side instead of completely hiding the Outline’s parent container.

Describe the solution you'd like

Two things:

  1. Theme Config to have something like “outlinePosition” that takes “left” or defaults to “right” and positions the outline correctly.
  2. Change the logic so that when frontmatter has outline set to hidden for a page that the entire Outline element is removed instead of it’s child elements which will prevent the left aligned Outline from creating a left side gap.

Describe alternatives you've considered

Using CSS to move the Outline element but it not fully work with frontmatter setting an outline to false on a specific page by creating an empty gap because the parent element of Outline is not removed.

Additional context

No response

Validations

@staghouse staghouse changed the title [Outline] Add support for left or right aligned Outline [Outline] Add support for left or right positioned Outline Mar 4, 2023
@kiaking kiaking added enhancement theme Related to the theme labels Mar 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants