Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): remove 720px breakpoint in home layout #347

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix(css): remove 720px breakpoint in home layout #347

merged 1 commit into from
Aug 20, 2021

Conversation

gcnyin
Copy link
Contributor

@gcnyin gcnyin commented Jul 29, 2021 •
edited by posva
Loading

Close #346

@gcnyin gcnyin changed the title remove @media (max-width: 720px) in Home.vue remove @media (max-width: 720px) in default theme Home.vue Jul 29, 2021
posva
posva approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make the spacing consistent with the rest of the content on the home page

@posva posva changed the title remove @media (max-width: 720px) in default theme Home.vue fix(css): remove 720px breakpoint in home layout Aug 20, 2021
@posva posva merged commit 0c1a1f2 into vuejs:master Aug 20, 2021
YunYouJun pushed a commit to YunYouJun/vitepress that referenced this pull request Aug 30, 2021
@gcnyin @YunYouJun
fix(css): remove 720px breakpoint in home layout (vuejs#347)
7c0d352
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

margin left/right is zero when home: true in default theme
2 participants
@gcnyin @posva