Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme optional banner(s) #4190

Closed
4 tasks done
jasonkuhrt opened this issue Sep 9, 2024 · 1 comment
Closed
4 tasks done

Default theme optional banner(s) #4190

jasonkuhrt opened this issue Sep 9, 2024 · 1 comment

Comments

@jasonkuhrt
Copy link

jasonkuhrt commented Sep 9, 2024

Is your feature request related to a problem? Please describe.

I was looking at the default theme extension slots for how to add a banner to the website but didn't find anything ideal. I ended up using nav bar content with some hacky CSS to create a new row, but this doesn't look great yet and it already took me a bit of time so far.

CleanShot 2024-09-09 at 17 20 02@2x

Describe the solution you'd like

I would like there to be a central place to pass some data to a banner content array that when populated will display a strip above the nav bar consisting of a colour and text.

Describe alternatives you've considered

A slot would work too, but lower level. I think banner is common enough to support is as first class data in the theme config?

Additional context

No response

Validations

@brc-dd
Copy link
Member

brc-dd commented Oct 2, 2024

Duplicate of #2071

@brc-dd brc-dd marked this as a duplicate of #2071 Oct 2, 2024
@brc-dd brc-dd closed this as completed Oct 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants