Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite prev/next link #61

Merged
merged 7 commits into from
Sep 5, 2020
Merged

feat: overwrite prev/next link #61

merged 7 commits into from
Sep 5, 2020

Conversation

Spice-Z
Copy link
Contributor

@Spice-Z Spice-Z commented Aug 2, 2020

This is built on top of #56, should be merged after it.
Enable to explicitly overwrite or disable prev/next link for individual pages setting like this

---
prev: false
next: /guide/getting-started
---

@kiaking
Copy link
Member

kiaking commented Sep 3, 2020

@Spice-Z Hi! Could you rebase this one to the latest since #56 is merged now 🙏

@Spice-Z
Copy link
Contributor Author

Spice-Z commented Sep 4, 2020

@kiaking
I merged latest change to this one!

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase! Just added 1 comment, please take a look.

@@ -1,13 +1,43 @@
import { defineComponent, computed } from 'vue'
import { usePageData } from 'vitepress'
import { useSiteData } from 'vitepress'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this one with the above import?

Suggested change
import { useSiteData } from 'vitepress'
import { usePageData, useSiteData } from 'vitepress'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Merged!!

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks you so much for this 🙌

@kiaking kiaking merged commit 1b96f63 into vuejs:master Sep 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants