Skip to content

Conversation

@HerringtonDarkholme
Copy link
Member

Fix #181

TS 2.6 seems to change Object.getOwnPropertyDescriptor

Note key is already the property name, there is no need to check null in runtime.

@ktsn
Copy link
Member

ktsn commented Nov 1, 2017

@HerringtonDarkholme Thanks! But npm run example still produce compile error as reported in the original thread like:

Type '<VC extends VueClass<Vue>>(target: VC) => VC' is not assignable to type 'typeof App'

@HerringtonDarkholme
Copy link
Member Author

That is another problem in Vuex's type definition.

@ktsn ktsn merged commit 95d9e65 into vuejs:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants