fix: pwa plugin should be ignored when target is not app

close #1497
vuejs · Jun 7, 2018 · 85e6e5e · 85e6e5e
1 parent 7d06f09
commit 85e6e5e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/@vue/cli-plugin-pwa/index.js b/packages/@vue/cli-plugin-pwa/index.js
@@ -1,5 +1,10 @@
 module.exports = (api, options) => {
  api.chainWebpack(webpackConfig => {
+ const target = process.env.VUE_CLI_BUILD_TARGET
+ if (target && target !== 'app') {
+ return
+ }
+
  const name = api.service.pkg.name
  const userOptions = options.pwa || {}
 

diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js
@@ -194,10 +194,9 @@ module.exports = class Service {
 
  // check if the user has manually mutated output.publicPath
  const target = process.env.VUE_CLI_BUILD_TARGET
- const exceptionTargets = ['lib', 'wc', 'wc-async']
  if (
  !process.env.VUE_CLI_TEST &&
- !exceptionTargets.includes(target) &&
+ (target && target !== 'app') &&
  config.output.publicPath !== this.projectOptions.baseUrl
  ) {
  throw new Error(