Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.version file contains 3.0.0-beta.15 in .rc3 npm package #1613

Closed
aweber1 opened this issue Jun 19, 2018 · 4 comments
Closed

.version file contains 3.0.0-beta.15 in .rc3 npm package #1613

aweber1 opened this issue Jun 19, 2018 · 4 comments

Comments

@aweber1
Copy link
Contributor

aweber1 commented Jun 19, 2018

Version

3.0.0-rc.3

Reproduction link

https://unpkg.com/@vue/cli@3.0.0-rc.3/lib/util/

Steps to reproduce

  • npm install -g @vue/cli
  • browse to global @vue/cli npm folder (on Windows \Users\{username}\AppData\Roaming\npm\node_modules\@vue\cli\lib\util)
  • open the .version file, it contains 3.0.0-beta.15

What is expected?

I assume the file should contain 3.0.0-rc.3 (or whatever happens to be the latest version). And that when creating a new app, the package devDependencies should be from the latest version. However, they are using the value from the .version file, e.g. 3.0.0-beta.15.

What is actually happening?

Looking at the @vue/cli/lib/util/getVersions.js file (https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli/lib/util/getVersions.js), the code appears to use that file as a version cache if the file hasn't been modified within the past 7 days.


I suspect perhaps the version number in the .version file was a result of a bad package? If not, then the getVersions.js code should compare the cached version against the latest version. I'll be submitting a PR with a change to check the cached version.

@andreydos
Copy link

Yes, this bug cause the problem in CI bamboo but at the same time build on local machine works fine.

@aweber1
Copy link
Contributor Author

aweber1 commented Jun 20, 2018

I encountered the issue on my local machine, with a clean npm cache.

@Akryum
Copy link
Member

Akryum commented Jun 20, 2018

@thetre97 This is unrelated. See #1582 (comment)

@Akryum Akryum closed this as completed Jun 20, 2018
@Akryum Akryum reopened this Jun 20, 2018
@travis-r6s
Copy link

Okay, thanks. Will delete as unrelated.

@Akryum Akryum closed this as completed in 9f0bf08 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants