TSlint rule "no-consecutive-blank-lines" doesn't work with vue-service tslint

[hdurix]

Version

3.0.0-rc.3

Reproduction link

https://github.com/hdurix/vue-consecutive-empty-lines

Steps to reproduce

Create a TypeScript project using vue cli.

Set no-consecutive-blank-lines to true (or remove it) in tslint.json

Change HelloWorld.vue to extract TypeScript in a dedicated file (HelloWorld.ts)

In HelloWorld.ts, add two consecutive empty lines.

In App.vue, add // @ts-ignore before the import statement (more information in #1576)

Launch npm run lint.

What is expected?

Consecutive empty lines are replaced by only one empty line.

What is actually happening?

The prompt says: No lint errors found.

---

The same thing works if we call directly tslint using tslint --project . --fix or if we run npm run serve.

I think, it comes from:

vue-cli/packages/@vue/cli-plugin-typescript/lib/tslint.js

Lines 24 to 26 in 838f6a2

	rules.set('no-consecutive-blank-lines', Object.assign({}, rule, {
	ruleSeverity: 'off'
	}))

.

[Akryum]

It's explained in the comment just above:

vue-cli/packages/@vue/cli-plugin-typescript/lib/tslint.js

Line 20 in 838f6a2

// so that we get correct line numbers in error reports for *.vue files.

[hdurix]

So @Akryum, why, there is a different behaviour between npm run serve and npm run lint?

Note: the problem is not with the Vue file but with the dedicated TypeScript file.

Is there a documentation to explain why some tslint rules are not allowed?

[Akryum]

there is a different behaviour between npm run serve and npm run lint

It wans't clear to me from your issue.

[backbone87]

why, there is a different behaviour between npm run serve and npm run lint?

I guess its because npm run serve runs tslint as part of a webpack build process and npm run lint calls a monkey-patched tslint directly. in the webpack process the rule isnt disabled.

[LinusBorg]

Exactly. And we patch tslint in the lint script to make it work with .vue files. It's a necessary hack.