fix: hook import not working

vuejs · Mar 14, 2022 · d259900 · d259900
1 parent ae4918f
commit d259900
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -101,5 +101,19 @@ module.exports = {
  'no-console': 'off',
  },
  },
+ {
+ files: [
+ 'packages/app-backend-core/src/hook.ts',
+ ],
+ rules: {
+ 'no-restricted-syntax': ['error', {
+ selector: 'ImportDeclaration',
+ message: 'File is injected with a `Function.toString()`, imports will not work',
+ }, {
+ selector: `CallExpression[callee.name='require']`,
+ message: 'File is injected with a `Function.toString()`, require will not work',
+ }],
+ },
+ },
  ],
 }
diff --git a/packages/app-backend-core/src/hook.ts b/packages/app-backend-core/src/hook.ts
@@ -1,5 +1,4 @@
 // this script is injected into every page.
-import { isBrowser, target } from '@vue-devtools/shared-utils'
 
 /**
  * Install the hook on window, which is an event emitter.
@@ -37,7 +36,7 @@ export function installHook (target, isIframe = false) {
 
  let iframeChecks = 0
  function injectToIframes () {
- if (!isBrowser) return
+ if (typeof window === 'undefined') return
 
  const iframes = document.querySelectorAll<HTMLIFrameElement>('iframe:not([data-vue-devtools-ignore])')
  for (const iframe of iframes) {