Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue3): prevent mixin leakage caused by inspection, fix #2037 #2038

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

lehni
Copy link
Contributor

@lehni lehni commented Mar 30, 2023

Description

See #2037 for description. I have tested this on Chrome and it works as expected.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@lehni lehni changed the title fix(vue3): prevent mixin leakage cause by inspection, fix #2037 fix(vue3): prevent mixin leakage caused by inspection, fix #2037 Mar 30, 2023
@lehni lehni force-pushed the fix/inspection-mixin-leak branch 2 times, most recently from 2367bce to 32baa7d Compare March 30, 2023 13:23
@lehni
Copy link
Contributor Author

lehni commented Apr 11, 2023

@himself65 I've accepted your change. CircleCI fails, I don't understand why.

@niksy
Copy link
Contributor

niksy commented Jun 7, 2023

What can we do to get this merged?

@lehni lehni force-pushed the fix/inspection-mixin-leak branch from 8339606 to a4a5602 Compare June 19, 2023 14:37
@lehni
Copy link
Contributor Author

lehni commented Sep 7, 2023

@yyx990803 pinging you again on this. This is save to merge, and it's a pretty bad bug, see https://github.com/vuejs/devtools/issues/2037

@liutkin
Copy link

liutkin commented Dec 15, 2023

Any ETA on this? This bug causes a huge mess in the large Vue app when global mixin is involved and computed keys being leaked into child components.

@Akryum Akryum merged commit 6ccd508 into vuejs:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants