Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment to one line of example #82

Open
tristanleboss opened this issue Jul 19, 2020 · 0 comments
Open

Add comment to one line of example #82

tristanleboss opened this issue Jul 19, 2020 · 0 comments

Comments

@tristanleboss
Copy link

tristanleboss commented Jul 19, 2020 •
edited
Loading

Hello,

I was reading the Usage section of the README.md file and one line lack a comment :

if (!module.hot.data) {

I have no ideea what this line does. I checked the WebPack HMR API doc and found one occurence of this property (https://webpack-v3.jsx.app/api/hot-module-replacement/):

This object will be available at module.hot.data after the update.

But it doesn't explain what's its purpose and what checking its existence implies.

Adding a comment to this line may help futur reader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tristanleboss