Skip to content

New scoped ID generation since v13.4 may cause duplicated ID (needs option to disable) #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whitetrefoil opened this issue Dec 6, 2017 · 2 comments

Comments

@whitetrefoil
Copy link

Version

13.5.0

Reproduction link

https://github.com/whitetrefoil/vue-ts-arch/blob/repo-1/src/components/my-global-comp/index.vue

Steps to reproduce

  1. npm install
  2. npx gulp build

What is expected?

4 .vue components get different scoped ID.

What is actually happening?

All 4 .vue component got the same scoped ID: data-v-5b49856c


Since v13.4.0 the scoped ID is calculated base on vue file content, but in my project I separated the content to separated files and all .vue files look same, all generated scoped ID are same.

It will be better if there's a option / switch to choose the previous way of id generation.

@whitetrefoil whitetrefoil changed the title New scoped ID generation since v13.4 may cause (needs option to disable) New scoped ID generation since v13.4 may cause duplicated ID (needs option to disable) Dec 6, 2017
@Jinjiang
Copy link
Member

Jinjiang commented Dec 6, 2017

From this case I think both the content and file path need to be hashed.
I will create a PR if you guys don't mind.
Thanks.

@yyx990803
Copy link
Member

fixed via #1086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants