Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slotOutlet fallback should include an function #1030

Merged
merged 4 commits into from
Apr 22, 2020
Merged

fix: slotOutlet fallback should include an function #1030

merged 4 commits into from
Apr 22, 2020

Conversation

underfin
Copy link
Member

fix #1021

@underfin
Copy link
Member Author

The fallback will be include into dynamicChildren with slotOutlet in runtime.so, should let it into wrapper funtion in compiler time.

@yyx990803 yyx990803 merged commit 2b19965 into vuejs:master Apr 22, 2020
@underfin underfin deleted the slot-fallback branch April 22, 2020 22:38
pikax pushed a commit to pikax/vue-next that referenced this pull request Apr 29, 2020
@underfin @pikax
fix(slots): compiled slot fallback should be functions (vuejs#1030)
8dbd5d0 
This avoids it being collected as dynamic children when it's not used.

fix vuejs#1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot set property 'nodeValue' of null happens when trying to sort table rows having a slot
2 participants
@underfin @yyx990803