fix(runtime-core): unable to set object to dom props #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove casting nullish values to ''
|
To me this makes the most sense, the null casting to an empty string seems to be a convenience layer only. However, this casting can be done in userland when desired, which firstly fixes #1049 and as the alternatives are computational heavy we can remove from the framework. |
blake-newman
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #1092. #1092 probably is quite expensive to do, since a new element is created per prop just to check if that prop is string assignable.
This PR removes casting nullish values to
''for props which I personally think will make more sense because user can expect default browser behaviour for setting<element>.prop.fix #1049