Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge 44 bug - Reactive props issue #1294

Closed
AlexandreBonaventure opened this issue Jun 4, 2020 · 4 comments · Fixed by #1302
Closed

Edge 44 bug - Reactive props issue #1294

AlexandreBonaventure opened this issue Jun 4, 2020 · 4 comments · Fixed by #1302

Comments

@AlexandreBonaventure
Copy link
Contributor

Version

3.0.0-beta.14

Reproduction link

https://github.com/AlexandreBonaventure/vue3-edge-bug

Steps to reproduce

Run the repro with yarn dev

What is expected?

on Chrome:

What is actually happening?

on Edge 44:


I haven't had the time to really dig into this issue but it seems like when we use Vue (transpiled for edgeHTML 18 with buble see #1285) there is an issue with how reactive props are delivered to children component, here item should not be undefined. However, reactivity seems to work for the parent component, you can see that the watchEffect hook is triggered correctly.

@AlexandreBonaventure

This comment has been minimized.

@allowing
Copy link

allowing commented Jun 5, 2020

#1284
iOS 12 got same

@AlexandreBonaventure
Copy link
Contributor Author

AlexandreBonaventure commented Jun 5, 2020

@allowing I don't think it is the same issue at all.


I fixed the issue here: #1302
Believe or not, I found one of the weirdest issue with destructuring on Edge 44, and this is what is causing the issue. Somehow, it seems like destructuring arrays with object syntax is straight up broken on edge 44. I had a hard time figuring it out just because it is so WTF. I've updated the repro to highlight this bug specifically https://github.com/AlexandreBonaventure/vue3-edge-bug/blob/master/src/edge-bug.html#L11
with line 11:

without line 11:

@yyx990803
Copy link
Member

Hmm, I used the index destructuring because it's slightly faster than array destructuring... but it probably won't be too significant.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants