fix(v-model): keep the same behavior as v-model with undefinedvalue with 2.x
#1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
changed the title
v-model with undefined insistent as 2.xv-model with undefinedvalue with 2.x
| @@ -85,6 +85,7 @@ export const vModelText: ModelDirective< | |||
| return | |||
| } | |||
| } | |||
| if (value === undefined || value === null) value = '' | |||
There was a problem hiding this comment.
Literally assigning NULL to native input value should has same effect. Probably checks value === null and value !== null is not required.
Check out example:
- Open: https://codesandbox.io/s/native-input-value-nwjoz?file=/index.js
- See console logs
posva
reviewed
Jul 6, 2020
| @@ -47,7 +47,7 @@ export const vModelText: ModelDirective< | |||
| HTMLInputElement | HTMLTextAreaElement | |||
| > = { | |||
| beforeMount(el, { value, modifiers: { lazy, trim, number } }, vnode) { | |||
| el.value = value | |||
| if (value !== undefined && value !== null) el.value = value | |||
There was a problem hiding this comment.
you should also be able to do
Suggested change
| if (value !== undefined && value !== null) el.value = value | |
| if (value != null) el.value = value |
posva
reviewed
Jul 6, 2020
| @@ -85,6 +85,7 @@ export const vModelText: ModelDirective< | |||
| return | |||
| } | |||
| } | |||
| if (value === undefined || value === null) value = '' | |||
There was a problem hiding this comment.
Same as above:
Suggested change
| if (value === undefined || value === null) value = '' | |
| if (value == null) value = '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1528