Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression v-model attr fallthrough for HOC component. #1543

Closed
AlexandreBonaventure opened this issue Jul 8, 2020 · 0 comments
Closed

Regression v-model attr fallthrough for HOC component. #1543

AlexandreBonaventure opened this issue Jul 8, 2020 · 0 comments

Comments

@AlexandreBonaventure
Copy link
Contributor

Version

3.0.0-beta.19

Reproduction link

https://jsfiddle.net/kfLbdvct/4/
here if you change the repro to load beta.18 it works as expected

Steps to reproduce

  1. Create a component that works with v-model
  2. Create an HOC component of the previous component
  3. use v-model on the HOC component

What is expected?

HOC component should forward the v-model value event to the child component

What is actually happening?

as per #1510
v-model event are not falling through anymore.
I thought this was actually a feature (not a bug), it was simplify a lot HOC creation by reducing boilerplate. I understand the reasoning behind the issue above, but I'm wondering if preventing v-model attr fallthrough in a HOC context was intentional.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant