Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): user-defined options.data of scss should be respected #1952

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Aug 24, 2020

vite 1.0.0-beta.9+ accepts cssPreprocessOptions but this ignores data option of scss/sass in vite.config.ts

This PR fix the issue

@yyx990803
Copy link
Member

Thanks - I changed it to additionalData since data is actually meant to be the entire source in node-sass usage, so I think additionalData is more explicit and avoids potential confusion. It also aligns with sass-loader.

@yyx990803 yyx990803 merged commit 9377352 into vuejs:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants