New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): dynamicChildren should be tracked correctly when normalizing slots to plain children #1987

Merged

yyx990803 merged 3 commits into vuejs:master from HcySunYang:fix-slot-rendering

Sep 1, 2020

Member

HcySunYang commented Aug 27, 2020

Fix: #1980

yyx990803 added 3 commits

September 1, 2020 12:10


          fix(runtime-core): enable block tracking when normalizing plain element

f510aa8

with slot children

fix #1980


          refactor: only enable tracking for compiled slots

1f2cd19


          test: fix object children normalization test case

1d0257b

Member

yyx990803 commented Sep 1, 2020

Nice job tracking this down. I refactored it to avoid creating an extra function for every compiled slot.

yyx990803 merged commit 5b82c48 into vuejs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet