fix(runtime-core): vnode.el is null in watcher after rerendering (fix #2170) #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An instance’s `el` property can be `null` inside a watcher after a component was rerendered (e.g. as a result of a changed prop). In an instance’s `update` method, the branch for handling mounted instances doesn’t set the `el` property of what will become the instance’s `vnode` property soon enough. Upon processing of the `updateComponentPreRender` function, the `el` property is then `null` which causes issues in watcher routines that rely on an instance’s `$el` property.
kleinfreund
deleted the
2170-fix-vnode-el-being-null-in-watcher-after-rerendering
branch
unbyte
added a commit
to unbyte/vue-next
that referenced
this pull request
Oct 6, 2020
yyx990803
pushed a commit
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instance’s
elproperty can benullinside a watcher after a component was rerendered (e.g. as a result of a changed prop). In an instance’supdatemethod, the branch for handling mounted instances doesn’t set theelproperty of what will become the instance’svnodeproperty early enough. Upon execution of theupdateComponentPreRenderfunction, theelproperty is thennullwhich causes issues in watcher routines that rely on an instance’s$elproperty.Fixes #2170.
(I have no knowledge of Vue’s internals besides what I gathered from trying to fix this bug, so the description here and the proposed change might not be adequate.)