Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): non-stable Fragment always need to diff its children #2445

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix(runtime-core): non-stable Fragment always need to diff its children #2445

merged 1 commit into from
Oct 20, 2020

Conversation

HcySunYang
Copy link
Member

close: #2444

@unbyte
Copy link
Contributor

unbyte commented Oct 20, 2020

I'm doubt about if the associated issue is a bug, because there is a problem with the code itself.

const block = Vue.ref({id:1});
// ...
<my-test v-for="id in [block.id]" :key="id" />

when block.value is null, [block.value.id] should not work.


a more appropriate sample works well: https://codepen.io/unbyte/pen/yLJaMVj?editors=1111

@HcySunYang
Copy link
Member Author

Consider this: https://codepen.io/hcysunyang/pen/LYZRWXp?editors=1111

@yyx990803 yyx990803 merged commit fff62e2 into vuejs:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onBeforeUnmount not invoked for specific dynamicChildren-optimized case
3 participants