Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/reactivity): error TS4058 caused by RefSymbol #2548

Merged
merged 1 commit into from
May 24, 2021

Conversation

glitchboyl
Copy link
Contributor

I'm use readonly() and pass a Ref type param, it will cause error TS4058 when I build it.

@viniciuskneves
Copy link

I'm having this very same issue when generating types using readonly

image

If I remove readonly it works as expected.

image

@yyx990803 or someone else I can tag to take a look into it?

@HcySunYang HcySunYang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: types labels Mar 31, 2021
@HcySunYang HcySunYang added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels May 8, 2021
@viniciuskneves
Copy link

Hey @HcySunYang , as a heads up, this #3317 has some discussion about this change. Please, also close there if this one gets merged.

@yyx990803 yyx990803 merged commit 90aa835 into vuejs:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants