Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): ensure readonly type prop on textarea is handled patched as attribute (close #2766) #2888

Merged

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Dec 26, 2020

the type prop is readonly on textareas but writeable for other form inputs. When swithcing between different input elements in dynamic components, the renderer might attempt do unset the type attribute, which throws when done through a DOMprop, but silently fails (as we want) when done with setAttribute, so we want the latter to be used.

close #2766

on textarea is handled patched as attribute

close #2766
@LinusBorg LinusBorg changed the title fix(runtime-dom): ensure readonly type prop fix(runtime-dom): ensure readonly type prop (close #2766) Dec 26, 2020
@LinusBorg LinusBorg changed the title fix(runtime-dom): ensure readonly type prop (close #2766) fix(runtime-dom): ensure readonly type prop on textarea is handled patched as attribute (close #2766) Dec 26, 2020
@github-actions
Copy link

Size report

Path Size
vue.global.prod.js 40.51 KB (-0.03% 🔽)
runtime-dom.global.prod.js 26.83 KB (-0.04% 🔽)
size-check.global.prod.js 16.21 KB (-0.1% 🔽)

@LinusBorg LinusBorg added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Dec 26, 2020
@yyx990803 yyx990803 merged commit c5d147c into master Feb 24, 2021
@yyx990803 yyx990803 deleted the linusborg/handle-readonly-type-attr-on-textarea-2766 branch February 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textarea attribute :type="null" throws error
2 participants