Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): component methods should override global properties in DEV #3074

Merged
merged 3 commits into from
Feb 5, 2021
Merged

fix(runtime-core): component methods should override global properties in DEV #3074

merged 3 commits into from
Feb 5, 2021

Conversation

HcySunYang
Copy link
Member

close: #3073

@posva
Copy link
Member

posva commented Jan 21, 2021

Will this fix it only on dev though? 🤔

@HcySunYang
Copy link
Member Author

Yeah, it's only occurs in dev

@posva
Copy link
Member

posva commented Jan 21, 2021

I see, I think that piece of code deserves a comment explaining why it's done as reading it doesn't explain why there is a different piece of code in dev and propd

@HcySunYang
Copy link
Member Author

Aha sure, added...

@posva
Copy link
Member

posva commented Jan 22, 2021

Nice! 🙌

@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global functions will override local functions
4 participants