Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssr] Error with KeepAlive: Cannot destructure property p of 'undefined' or 'null' #3255

Closed
rstoenescu opened this issue Feb 18, 2021 · 2 comments · Fixed by #3259
Closed

[ssr] Error with KeepAlive: Cannot destructure property p of 'undefined' or 'null' #3255

rstoenescu opened this issue Feb 18, 2021 · 2 comments · Fixed by #3259
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr

Comments

@rstoenescu
Copy link

rstoenescu commented Feb 18, 2021 •
edited
Loading

Version

3.0.5

Reproduction link

https://github.com/rstoenescu/vue3-ssr-bug-keepalive

Steps to reproduce

  1. yarn
  2. yarn dev
  3. Error being reported (from src/pages/Home.js):
TypeError: Cannot destructure property `p` of 'undefined' or 'null'.
    at setup (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:2498:27)
    at callWithErrorHandling (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:156:22)
    at setupStatefulComponent (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6377:29)
    at setupComponent (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6338:11)
    at renderComponentVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:160:17)
    at renderVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:248:22)
    at renderVNodeChildren (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:263:9)
    at renderElementVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:299:17)
    at renderVNode (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:245:17)
    at renderComponentSubTree (/Users/Razvan/work/test/vue3-ssr-bug-keepalive/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:217:13)

What is expected?

Not to error out

What is actually happening?

Error from vue core
@rstoenescu rstoenescu mentioned this issue Feb 18, 2021
Closed
@gryphonmyers
Copy link

Oh, umm I just filed this same bug under vue-router: vuejs/router#778

You sure this is a core bug and not a bug with the implementation of router-view?

@HcySunYang HcySunYang mentioned this issue Feb 19, 2021
Merged
@HcySunYang HcySunYang added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Feb 19, 2021
@gryphonmyers
Copy link

Seems like it - I'll close my dupe. Sorry for the noise!

yyx990803 pushed a commit that referenced this issue Mar 22, 2021
@HcySunYang
fix(KeepAlive): adapt keepalive for ssr (#3259)
e8e9b00 
fix #3255
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(KeepAlive): adapt keepalive to ssr
4 participants
@yyx990803 @rstoenescu @gryphonmyers @HcySunYang