Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): should not rewrite scope variable #3449

Merged
merged 3 commits into from
Mar 25, 2021
Merged

fix(compiler-sfc): should not rewrite scope variable #3449

merged 3 commits into from
Mar 25, 2021

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Mar 19, 2021 •
edited
Loading

fix #3445

@edison1105 edison1105 changed the title fix(compiler-sfc): rewrite variable corrently fix(compiler-sfc): avoid rewrite variable if has same name scoped variable declaration in parent block Mar 19, 2021
@edison1105 edison1105 marked this pull request as draft March 19, 2021 12:15
@edison1105 edison1105 marked this pull request as ready for review March 19, 2021 15:05
@edison1105 edison1105 changed the title fix(compiler-sfc): avoid rewrite variable if has same name scoped variable declaration in parent block fix(compiler-sfc): should not rewrite scope variable Mar 19, 2021
@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 22, 2021
@edison1105 edison1105 requested a review from HcySunYang March 22, 2021 05:31
@yyx990803 yyx990803 merged commit bbc5fe6 into vuejs:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HcySunYang HcySunYang HcySunYang approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimental "ref sugar": local variables sharing a name with a top-level ref are overwritten
3 participants
@edison1105 @HcySunYang @yyx990803