Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teleport + HMR + async ref mutation breaks on component edit #3641

Closed
zigomir opened this issue Apr 21, 2021 · 0 comments · Fixed by #3642
Closed

teleport + HMR + async ref mutation breaks on component edit #3641

zigomir opened this issue Apr 21, 2021 · 0 comments · Fixed by #3642
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: hmr

Comments

@zigomir
Copy link

zigomir commented Apr 21, 2021

Version

3.0.11

Reproduction link

https://github.com/zigomir/teleport-hmr-repro

Steps to reproduce

I tried putting reproduction on to codesandbox, but HMR wouldn't work there anyway, so it's better to do locally.

  1. git clone git@github.com:zigomir/teleport-hmr-repro.git
  2. yarn or npm install
  3. yarn dev or npm run dev
  4. open http://localhost:3000 and open browser dev tools
  5. see how random number is refreshing every second
  6. edit App.vue and see error in console & random error not re-rendering anymore, aka app breaks
  7. if you comment out teleport tag and reload page, HMR works and random number updates as expected

Might be related to #3560 but not sure.

What is expected?

HMR and app keep working.

What is actually happening?

It breaks.
@HcySunYang HcySunYang added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: hmr labels Apr 21, 2021
@HcySunYang HcySunYang mentioned this issue Apr 21, 2021
Merged
yyx990803 pushed a commit that referenced this issue May 7, 2021
@HcySunYang
fix(Teleport): avoid changing the reference of vnode.dynamicChildren (#…
43f7815 
…3642)

fix #3641
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: hmr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Teleport): avoid changing the reference of vnode.dynamicChildren
2 participants
@zigomir @HcySunYang