fix(types): prioritize promise based push/replace

vuejs · Aug 8, 2019 · 1243e8b · 1243e8b
1 parent ff8abe0
commit 1243e8b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/types/router.d.ts b/types/router.d.ts
@@ -23,10 +23,10 @@ export declare class VueRouter {
   beforeEach (guard: NavigationGuard): Function;
   beforeResolve (guard: NavigationGuard): Function;
   afterEach (hook: (to: Route, from: Route) => any): Function;
-  push (location: RawLocation, onComplete?: Function, onAbort?: ErrorHandler): void;
-  replace (location: RawLocation, onComplete?: Function, onAbort?: ErrorHandler): void;
   push (location: RawLocation): Promise<Route>;
   replace (location: RawLocation): Promise<Route>;
+  push (location: RawLocation, onComplete?: Function, onAbort?: ErrorHandler): void;
+  replace (location: RawLocation, onComplete?: Function, onAbort?: ErrorHandler): void;
   go (n: number): void;
   back (): void;
   forward (): void;

diff --git a/types/test/index.ts b/types/test/index.ts
@@ -159,7 +159,16 @@ router.push({
 router.replace({ name: "home" });
 
 router.push('/', () => {}, () => {})
-router.replace('/foo', () => {}, () => {});
+router.replace('/foo', () => {}, () => {})
+
+// promises
+
+router
+  .push('/')
+  .then(route => {
+    route.fullPath
+  })
+  .catch(() => {})
 
 router.onReady(() => {});