-
Notifications
You must be signed in to change notification settings - Fork 669
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: revert default element typings to
HTMLElement
The type definitions were updated to allow generic element typing in #1871 However, this "loosened" the default type from `HTMLElement` to `Element. This was actually a breaking change. For example, consumers may have had this test code: ```ts wrapper.element.click() ``` But `click()` only exists on `HTMLElement`, not on `Element`, so test compilation fails. This change moves the default type back to `HTMLElement`. If we want to loosen this requirement in the future, it should be considered a breaking change.
- Loading branch information
1 parent
d56d945
commit d34b00b
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters