Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scoped slots typing #1022

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Fix scoped slots typing #1022

merged 2 commits into from
Nov 9, 2018

Conversation

healqq
Copy link
Contributor

@healqq healqq commented Nov 9, 2018 •
edited
Loading

Scoped slot attribute accepts functions, but typing allows only Record<string, string>
Updated typings, added test for scoped slots types

eddyerburgh
eddyerburgh approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddyerburgh eddyerburgh merged commit 8db0c20 into vuejs:dev Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@healqq @eddyerburgh