Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: undefined attributes parsed as $attrs #1029

Merged
merged 2 commits into from
Nov 23, 2018
Merged

feat: undefined attributes parsed as $attrs #1029

merged 2 commits into from
Nov 23, 2018

Conversation

abilicz
Copy link
Contributor

@abilicz abilicz commented Nov 18, 2018

making setProps method more consistent with the actual Vue behavior.

@abilicz abilicz mentioned this pull request Nov 18, 2018
Closed
eddyerburgh
eddyerburgh approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

@eddyerburgh eddyerburgh merged commit 0d3e46d into vuejs:dev Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abilicz @eddyerburgh