fix: use Vue async option for sync mode #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes many bugs caused by the current synchronous implementation by using an async option added to Vue 2.5.18.
Note:
This change introduces a bug shown in this fiddle. Since this is an unusual usage of
$children
we have decided to move forward with this PR. However, there may be other edge cases. If there are many more edge cases, then we will remove sync functionality from Vue Test Utils.