Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support plugin with multi version vue (#5970) #5985

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Jun 27, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Kingwl
Copy link
Member Author

Kingwl commented Jun 27, 2017

@gebilaoxiong @posva
in this commit
i hold the plugin reference in Vue
but i'm bot sure that is a good practice
please give me some advice😂

@posva
Copy link
Member

posva commented Jun 27, 2017

You're on 🔥 man!
It looks ok to me

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it's great!
look good to me too.

@Kingwl
Copy link
Member Author

Kingwl commented Jun 28, 2017

@posva @kazupon thanks😁

@yyx990803 yyx990803 merged commit 049f317 into vuejs:dev Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants