Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): relax $options type for TS2.6+ #6819

Merged
merged 1 commit into from
Oct 15, 2017

Conversation

HerringtonDarkholme
Copy link
Member

@HerringtonDarkholme HerringtonDarkholme commented Oct 15, 2017

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

TS2.6 introduces strict function variance. $options's type breaks variance check. Relaxing the signature solves this. (We need TS2.6RC to break existing code, this fix is tested locally)

@plantain-00
Copy link

Can this released as a patch now? the typescript@2.6.1 is released now.

erweixin pushed a commit to erweixin/vue that referenced this pull request Dec 15, 2017
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants