Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue-server-renderer | Webpack 4 deprecation warning for plugins #8810

Closed
AlexDubok opened this issue Sep 18, 2018 · 2 comments
Closed

vue-server-renderer | Webpack 4 deprecation warning for plugins #8810

AlexDubok opened this issue Sep 18, 2018 · 2 comments

Comments

@AlexDubok
Copy link

What problem does this feature solve?

In webpack 4 there is a deprecation warning about the Tapable.plugin being deprecated.

What does the proposed API look like?

Change compiler.plugin to compiler.hooks.[hookname] to support new tappable syntax.

The question is what is the preferred way to support new syntax while leaving Webpack 2-3 compatibility?
@jonaskuske
Copy link
Contributor

jonaskuske commented Sep 21, 2018 •
edited
Loading

Already fixed in vuejs/vue#7839, will land in master as part of Vue v2.6 :)

@AlexDubok
Copy link
Author

OK, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexDubok @jonaskuske