Skip to content

Vue School Black Friday Announcement #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Conversation

rahaug
Copy link
Contributor

@rahaug rahaug commented Nov 22, 2019

This PR adds a banner on top of vuejs.org to inform users about Vue School’s Black Friday Promotion.

The banner is a non-sticky, closable, banner for the top that opens Vue School's Black Friday page in a new tab.

The banner will not reappear if a user has closed it (stored in local storage).

The banner respects the different sidebar behavior on the home page and the guide, on mobile, tablet, and desktop.

As discussed in email, we’ve based the promotion on a previously used marketing banner.

Visuals
Desktop Demo
Tablet Demo
Mobile Demo

@phanan
Copy link
Member

phanan commented Nov 22, 2019

Pinging @yyx990803.

@yyx990803 yyx990803 merged commit 6b9cbf6 into vuejs:master Nov 25, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Nov 25, 2019

Hey @rahaug, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@rahaug rahaug mentioned this pull request Dec 6, 2019
@rahaug rahaug deleted the vueschool-banner branch March 18, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants