fix($plugin-active-header-links): side navigation edge case bug (#1477)

KyleJShaver · ulivz · commit 8a11d1455d7b · 2019-03-27T22:39:50.000+08:00
diff --git a/packages/@vuepress/plugin-active-header-links/clientRootMixin.js b/packages/@vuepress/plugin-active-header-links/clientRootMixin.js
@@ -40,12 +40,12 @@ export default {
 
         const routeHash = decodeURIComponent(this.$route.hash)
         if (isActive && routeHash !== decodeURIComponent(anchor.hash)) {
-          let activeAnchor = anchor
+          const activeAnchor = anchor
           // check if anchor is at the bottom of the page to keep $route.hash consistent
           if (bottomY === scrollHeight) {
             for (let j = i + 1; j < anchors.length; j++) {
               if (routeHash === decodeURIComponent(anchors[j].hash)) {
-                activeAnchor = anchors[j]
+                return
               }
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -40,12 +40,12 @@ export default {`
`40`	`40`
`41`	`41`	`const routeHash = decodeURIComponent(this.$route.hash)`
`42`	`42`	`if (isActive && routeHash !== decodeURIComponent(anchor.hash)) {`
`43`		`- let activeAnchor = anchor`
	`43`	`+ const activeAnchor = anchor`
`44`	`44`	`// check if anchor is at the bottom of the page to keep $route.hash consistent`
`45`	`45`	`if (bottomY === scrollHeight) {`
`46`	`46`	`for (let j = i + 1; j < anchors.length; j++) {`
`47`	`47`	`if (routeHash === decodeURIComponent(anchors[j].hash)) {`
`48`		`- activeAnchor = anchors[j]`
	`48`	`+ return`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`	`}`