-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong "Edit in github" url with Permalinks. #1425
Labels
has PR
Has a related PR
Comments
Can you provide more config information? This is my config, and it works. module.exports = {
themeConfig: {
repo: 'YunYouJun/software-engineering-note',
docsDir: 'docs',
editLinks: true,
editLinkText: 'Edit in GitHub'
}
} |
You should provide more details. What is your |
This issue will be fixed by #1419 😄 |
ok thanks! |
Fixed at #1419 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Version
1.0.0-alpha.43
Steps to reproduce
What is expected?
When setting a permalink configuration and clicking on the "edit on github" link, the link should target the right place of the page in the repo.
What is actually happening?
The link is wrong, and target the permalink path.
Other relevant information
I've also the blog plugin.
The text was updated successfully, but these errors were encountered: