-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(navbar): fix styles when navbar is not present #316
Conversation
Can you provide more context? I cannot repro this bug. |
When a page has no navbar ( This is especially evident when we use a Custom Layout and we don't want to have a navbar. Example:HomeLayout.vue<template>
<div class="container">
<vue-nixie-clock></vue-nixie-clock>
</div>
</template>
<style scoped>
.container {
align-items: center;
background-color: #000;
display: flex;
height: 100vh;
justify-content: center;
}
.nixie-clock {
width: 800px;
}
</style> README.md
BeforeAfter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked at my local and LGTM, only a small question.
h1, h2, h3, h4, h5, h6 | ||
margin-top 1.5rem | ||
padding-top 0 | ||
.sidebar | ||
top 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need reset top: 0
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! |
Before
After