fix: menu compatibility with IE (node type statement) (#1365)

* fix: compare node by type dom constructors do not have name property in IE. replace that with comparing by their node type. fix #1263 * fix(MdMenuContent): height for IE got height `0` with style `flex-direction: column` fix #1263
vuematerial · Jan 3, 2018 · a4c03be · a4c03be
1 parent fe1ec4a
commit a4c03be
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/components/MdMenu/MdMenuContent.vue b/src/components/MdMenu/MdMenuContent.vue
@@ -248,7 +248,7 @@
     max-width: $md-menu-base-width * 5;
     max-height: 35vh;
     display: flex;
-    flex-direction: column;
+    flex-direction: row;
     position: absolute;
     z-index: 60;
     border-radius: 2px;

diff --git a/src/components/MdPopover/MdPopover.vue b/src/components/MdPopover/MdPopover.vue
@@ -91,7 +91,7 @@
         if (this.mdSettings) {
           const options = deepmerge(this.getPopperOptions(), this.mdSettings)
 
-          if (this.$el.constructor.name.toLowerCase() !== 'comment') {
+          if (this.$el.nodeType !== Node.COMMENT_NODE) {
             this.popperInstance = new Popper(this.originalParentEl, this.$el, options)
           }
         }

diff --git a/src/components/MdPortal/MdPortal.js b/src/components/MdPortal/MdPortal.js
@@ -98,7 +98,7 @@ export default {
     async initDestroy (manualCall) {
       let el = this.$el
 
-      if (manualCall && this.$el.constructor.name.toLowerCase() === 'comment') {
+      if (manualCall && this.$el.nodeType === Node.COMMENT_NODE) {
         el = this.$vnode.elm
       }