fix: node type statement(menu compatibility with IE) #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VdustR
changed the title
marcosmoura
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dom constructors do not have name property in IE.
Replace that with comparing by their node type.
Tested with chrome and IE(with #1342), both got
1stand for normal element and got8for comment.Related to #1263There is another bug with #1263 thatmenuHeightis always0therefore menu still not works in IE with this change yet.update: fix height with 24d927c, similar to #1356
fix #1263
IE11 & edge in Win10(VirtualBox), firefox & chrome in Xubuntu tested.
MdMenu,MdSelect,MdAutocompletetested.