fix(MdFieldMixin) Preserve the name attribute on change #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
reviewed
Jan 12, 2018
marcosmoura
approved these changes
Jan 12, 2018
|
when this change gonna be in the release (atleast in next beta) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a codepen which demonstrates an issue: https://codepen.io/jastkand/pen/EoQGKV
You can open a devtools and see that there are
nameattributes oninputandtextarea. When you try to change any input thenameattribute will be removed which is not an expected behavior.This also should fix this issue #1278, because serialization uses
nameattributes