Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MdButton): Ripple for firefox #1468

Merged
merged 5 commits into from
Feb 20, 2018
Merged

fix(MdButton): Ripple for firefox #1468

merged 5 commits into from
Feb 20, 2018

Conversation

VdustR
Copy link
Member

@VdustR VdustR commented Feb 2, 2018 •
edited
Loading

  • new props md-event-trigger for MdRipple to disable event listener.
  • Use method call instead of event trigger to make ripple work with firefox because event could not be triggered on element in button with firefox.
  • cancel touchstart, touchmove, touchend, mousedown, mouseup stopPropagation to make button listeners works.

fix #1461

@marcosmoura marcosmoura merged commit 156506b into vuematerial:dev Feb 20, 2018
@VdustR VdustR deleted the fix#1461 branch February 20, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MdRipple] does not work on buttons in Firefox
2 participants
@VdustR @marcosmoura