Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print preview effect problem? #15

Closed
Jairwin-L opened this issue Feb 4, 2024 · 5 comments
Closed

print preview effect problem? #15

Jairwin-L opened this issue Feb 4, 2024 · 5 comments
Labels

Comments

@Jairwin-L
Copy link

Description

the print preview effects of the two versions are different. the v2 version should be the same as v1, right?
v2.x.
image
image
v1.x.
image
image

@Mister-Hope
Copy link
Member

Why do you think expanding the link could be bad? At least it gives reference for what the link is pointing.

You could definitely disable this via css.

@Jairwin-L
Copy link
Author

Jairwin-L commented Feb 5, 2024

A scenario I have encountered at present is that if you make a resume, after printing it out, the redundant links displayed will make the entire page take up a lot of space; at the same time, the readability is not high.

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 5, 2024

If a page is a good printable one, anyone should not expect to see lots of external links in it. For example, a normal blog post should mainly contain plain text and links to other articles in current site, instead of adding lots of references in lines.

Besides, we are only printing external links, which is not attachable even if you print all pages, so we think that it's better to declare their address. Printing links pointing to current site is a bad idea, I agree with that.

You can easily hide your website links with CSS:

a {
  @media print {
    &[href^="http://"],
    &[href^="https://"]
    {
      &::after {
        content: ''!important;
      }
    }
  }
}

Do you still need any further discussion?

@Jairwin-L
Copy link
Author

Jairwin-L commented Feb 5, 2024

Of course, what you are talking about is also from one aspect, and I should be able to understand it.
My main points here are: there are external links because they can be accessed online, and they are printable so that readers can directly print the original content. Even if there are links, they are displayed in text form. As you said, it can be solved through CSS. I also agree with this.
Because I saw that v2 is different from v1, I suddenly wanted to know more about this aspect. Of course, there may be a blind spot in my knowledge in this aspect.

Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot added the stale label Feb 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants