Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Language selector on top bar is not correctly displayed. #1206

Closed
jnuricumbo opened this issue Oct 27, 2020 · 1 comment · Fixed by #1211
Closed

[BUG] Language selector on top bar is not correctly displayed. #1206

jnuricumbo opened this issue Oct 27, 2020 · 1 comment · Fixed by #1211

Comments

@jnuricumbo
Copy link
Contributor

Description

  • I'm using canary version
  • Language selector on top bar is not correctly displayed when shopware has only one language configured.
    Screenshot from 2020-10-27 23-59-17
  • If only one language available (not en-GB) then this is not automatically selected/applied.
    • Changing locale in packages/default-theme/src/store/index.js does not take effect.
    • What is the correct way to override locale in my project?
  • Currency works as expected when only one currency.

Steps to reproduce

  • Configure your shopware endpoint with only one language other than english i.e. de-DE
  • Now selector is not correctly displayed.
@jnuricumbo jnuricumbo changed the title [Bug] Language selector on top bar is not correctly displayed. [BUG] Language selector on top bar is not correctly displayed. Oct 28, 2020
@jnuricumbo
Copy link
Contributor Author

If default language is not en-GB then it should be set as default in shopware-pwa.config.js using defaultLanguageCode . Is there any documentation with all available options?

#1211 hides the switcher when only one language available, exactly as currency switcher does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant