Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pagination not displaying correctly with more than 5 pages #1209

Closed
niklaswolf opened this issue Oct 28, 2020 · 0 comments · Fixed by #1267
Closed

[BUG] Pagination not displaying correctly with more than 5 pages #1209

niklaswolf opened this issue Oct 28, 2020 · 0 comments · Fixed by #1267
Assignees
@mkucmus
Labels
bug Something isn't working
Milestone
v0.6.0

Comments

@niklaswolf
Copy link
Collaborator

Describe the bug

The pagination on category/product listing pages does not work correctly. It doesn't show up on the demo instance because there are no categories with more than 5 pages.
It doesn't work because the computed currentPage from the SfPagination component does not get updated correctly, see screenshot from vue devtools below.

Additional context

This is what the pagination looks like with page = 6
Bildschirmfoto 2020-10-28 um 15 01 03
Screenshot from Vue DevTools
Bildschirmfoto 2020-10-28 um 15 00 15
@niklaswolf niklaswolf added the bug Something isn't working label Oct 28, 2020
@mkucmus mkucmus self-assigned this Oct 30, 2020
@mkucmus mkucmus added this to the v0.6.0 milestone Oct 30, 2020
@mkucmus mkucmus mentioned this issue Dec 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkucmus mkucmus

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

fix(default-theme): watch correct pagination param vuestorefront/shopware-pwa
2 participants
@mkucmus @niklaswolf