Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] shippingAddress from useOrderDetails undefined #1844

Closed
1 task done
niklaswolf opened this issue Mar 9, 2022 · 0 comments · Fixed by #1847
Closed
1 task done

[Bug] shippingAddress from useOrderDetails undefined #1844

niklaswolf opened this issue Mar 9, 2022 · 0 comments · Fixed by #1847
Assignees
@mkucmus
Labels
bug Something isn't working

Comments

@niklaswolf
Copy link
Collaborator

What happened?

Seems like the computation in useOrderDetails is not correct anymore.

shopware-pwa/packages/composables/src/logic/useOrderDetails.ts

Line 121 in ccc5e70

const shippingAddress = computed(

Shopware 6.4.8.1 has no location property on the OrderDeliveryEntity

should be .deliveries[0]?.shippingOrderAddress in my view.

Steps To Reproduce

No response

Is there an existing issue for this?

  • I have searched the existing issues

Version

Canary (generated by CLI)

Which element is affected?

composables

Environment

- Shopware API: 6.4.8.1
- Shopware PWA version: canary

Relevant log output

No response
@niklaswolf niklaswolf added the bug Something isn't working label Mar 9, 2022
@mkucmus mkucmus self-assigned this Mar 10, 2022
@mkucmus mkucmus mentioned this issue Mar 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkucmus mkucmus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(composables): correct delivery address source vuestorefront/shopware-pwa
2 participants
@mkucmus @niklaswolf