feat(default-theme): Add service menu #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mkucmus
requested changes
Jun 8, 2022
Comment on lines
4
to
5
| :key="navigationElements[0].id" | ||
| :category="navigationElements[0]" |
There was a problem hiding this comment.
please move key and category to the setup method as computed properties, using optional chaining there and will be ready 💪🏻
| </template> | ||
| <script> | ||
| import { getTranslatedProperty } from "@shopware-pwa/helpers" | ||
| import { ref } from "@vue/composition-api" |
There was a problem hiding this comment.
this import is not necessary
mkucmus
approved these changes
Jun 9, 2022
…eat/add-service-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR closes #1890
SwFooterNavigationColumnto contains the UI of footer column.SwFooterServiceto fetch service menu from useNavigation.SwFooterNavigationcomponent.Checklist
useNavigationcomposable is used to fetchservice-menupredefined type of navigation