Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default-theme): improve performance #1962

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

quando1910
Copy link
Collaborator

@quando1910 quando1910 commented Oct 19, 2022

Changes

  • move logic inside SwProductCard to a new components. This will reduce unnecessary code when dev try to override slot product-card
  • loading eager will help reduce memory leaks on Safari & firefox

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
shopware-pwa-docs ⬜️ Ignored (Inspect) Oct 19, 2022 at 10:09AM (UTC)

@patzick patzick merged commit 1655823 into master Oct 19, 2022
@patzick patzick deleted the feat/improve-performance branch October 19, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants