Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty URLs in category-> product links #210

Closed
patzick opened this issue Dec 12, 2019 · 1 comment
Closed

Pretty URLs in category-> product links #210

patzick opened this issue Dec 12, 2019 · 1 comment
Assignees
@mkucmus
Labels
Blocked Category Page URL
Milestone
Developer Preview

Comments

@patzick
Copy link
Collaborator

patzick commented Dec 12, 2019

No description provided.

@patzick patzick mentioned this issue Dec 16, 2019
Merged
@patzick
Copy link
Collaborator Author

patzick commented Dec 16, 2019

@mkucmus @rmakara @krskibin this just needs to be changed after fixing shopware URLs, but the task is done for now.

https://github.com/DivanteLtd/shopware-pwa/blob/1bbde207e492a5c2ef9cf528a1eec69429bcee29/packages/helpers/src/product/getProductUrl.ts#L3-L11

@patzick patzick closed this as completed Dec 16, 2019
@rmakara rmakara added this to the Developer Preview milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkucmus mkucmus

Labels
Blocked Category Page URL
Projects
None yet
Milestone
Developer Preview
Development

No branches or pull requests
3 participants
@rmakara @mkucmus @patzick